Skip to content

Conversation

EQuimper
Copy link
Contributor

@EQuimper EQuimper commented Aug 19, 2025

Fixes APP-2933

What changed (plus any additional context for devs)

Did fix the padding at the bottom.

Always add safe area padding because since the RN upgrade the navigation bar is always transparent

Screen recordings / screenshots

Before

image

After the fix

image

What to test

I tested on Samsung Galaxy S24 and Pixel 5

Copy link

linear bot commented Aug 19, 2025

@jinchung
Copy link
Member

Launch in simulator or device for 8accd5d

@ibrahimtaveras00 ibrahimtaveras00 self-requested a review August 20, 2025 15:32
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few issues came up during testing:

Issue 1:

Send flow, when the keyboard is in a dismissed state, the native bar overlaps with a lot of our buttons at the bottom of the screen

Seen here:
Screenshot 2025-08-22 at 10 31 52 AM
Screencast here:
https://github.com/user-attachments/assets/08d874b0-a30d-4061-bc0b-27be965e81e2

Steps to reproduce:

  • on send flow you must dismiss keyboard

Issue 2:

When I import my ledger nano hardware wallet, and attempt to do an NFT send, the native bar at bottom overlaps with tap to send button

Seen here:
https://github.com/user-attachments/assets/71523938-1fc0-4dd0-bcb4-8e9e7f81bf2f
Screenshot 2025-08-22 at 10 42 23 AM

Steps to reproduce:

  • You need a ledger nano x hardware wallet to reproduce this
  • import ledger nano x wallet
  • ensure that wallet has an NFT to send
  • attempt to send an NFT

Issue 3:

When in light mode, I can not see the native bar at the bottom

Seen here:

Screen.Recording.2025-08-22.at.10.35.17.AM.mov

Steps to reproduce:

  • Navigate to settings > theme
  • change theme to light
  • notice how navigating the app it's hard to see the buttons at the native bar

Issue 4:

When attempting to edit an ENS profile, the buttons overlap, as well as when attempting to create an ENS

Seen here:
https://github.com/user-attachments/assets/d2e6b333-2f04-4346-a0b6-f5fb138722df

Steps to reproduce:

  • use 0xtester.eth wallet
  • navigate to discover screen
  • scroll down and tap on create your ens profile card
  • tap the "Edit 0xtester.eth" button

@janicduplessis
Copy link
Contributor

@ibrahimtaveras00 Do you know if those happen on develop too? Might be better to address in a follow up if this is the case. I think it might be related to the RN upgrade.

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janicduplessis Good call, all issues exist currently in develop, so I will create a separate linear issue to tackle separately outside the scope of this PR

With that being said, the original scope of this fix for this PR looks good, QA Passed

@janicduplessis janicduplessis merged commit b8290a0 into develop Aug 22, 2025
16 checks passed
@janicduplessis janicduplessis deleted the eq/APP-2933-fix-in-app-browser-padding-android branch August 22, 2025 16:41
@ibrahimtaveras00
Copy link
Contributor

@janicduplessis Good call, all issues exist currently in develop, so I will create a separate linear issue to tackle separately outside the scope of this PR

With that being said, the original scope of this fix for this PR looks good, QA Passed

https://linear.app/rainbow/issue/APP-3035/other-padding-issues-found-during-6813-qa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants