Filtering Job Arguments #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rosa merged 18 commits into rails:main from basecamp:filter-job-args

Jul 30, 2025

+126 −5

Contributor

intrip commented Jul 29, 2025 •

edited

Loading

Adds a new filter_arguments option that allows you to filter out sensitive data from job arguments.

Note: Currently, only root-level hash keys are supported. If needed, support for key paths, procs, and regular expressions could be added in the future.

intrip force-pushed the filter-job-args branch from 6b6a4cb to 0a37f71 Compare

July 29, 2025 14:32


          Filtering Job Arguments

cebc01b

Adds a new `filter_arguments` option that allows you to filter out sensitive data from job arguments.
This option can be configured globally or per application.

Note: Currently, only root-level hash keys are supported.
If needed, support for key paths, procs, and regular expressions could be added in the future.

intrip force-pushed the filter-job-args branch from 0a37f71 to cebc01b Compare

July 29, 2025 14:42

rosa reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved


          SolidQueue and Resque are the main adapters supported

f26739d

So remove the limitation from the Readme

rosa reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved


          Leftover

01fb512

Member

rosa commented Jul 29, 2025

Thanks @intrip! I don't think it's worth having this per-application. I think this should be a global setting like all the settings listed here.


          Remove the per-app override

3f2e086

intrip force-pushed the filter-job-args branch from 8967fbe to 3f2e086 Compare

July 29, 2025 15:51

Contributor Author

intrip commented Jul 29, 2025

Thanks @intrip! I don't think it's worth having this per-application. I think this should be a global setting like all the settings listed here.

Sure! removed it


          Specify that are strings

202227f

rosa reviewed

View reviewed changes

lib/active_job/job_argument_filter.rb Outdated Show resolved Hide resolved


          Move to MissionControl NS

7314d09

rosa reviewed

View reviewed changes

lib/active_job/queue_adapters/resque_ext.rb Outdated Show resolved Hide resolved

rosa reviewed

View reviewed changes

lib/mission_control/job_argument_filter.rb Outdated Show resolved Hide resolved

rosa reviewed

View reviewed changes

lib/mission_control/job_argument_filter.rb Outdated Show resolved Hide resolved

intrip added 10 commits

July 30, 2025 09:46


          Don't modify raw_args

8bd6eef

They are used for job handling logic e.g. retries.


          Move .first up

aae059a


          It's args_arr

d06241f


          Extra newline

829585d


          No need for the if

2a65be8


          Extra new line

e38837b


          No need to memoize a fast operation

d1b77bc


          Comment

f1d8485


          Test

ba97206


          Rewording

rosa reviewed

View reviewed changes

lib/active_job/queue_adapters/resque_ext.rb Outdated Show resolved Hide resolved

rosa approved these changes

View reviewed changes

Member

rosa left a comment

Awesome! Just left a minor comment but this is ready 🙏


          Fix cop

80d6837


          Rename to extract_args_hash

acb8cca

And return an hash or nil

rosa merged commit 1648c00 into rails:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet