Add labels to filter fields #268
Merged
+32
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycandrea
commented
Jul 9, 2025
| <% if jobs_status == "finished" %> | ||
| <% if jobs_status == "finished" %> | ||
| <div class="control"> | ||
| <%= form.label :finished_at_start, class: "label" %> |
There was a problem hiding this comment.
I don't love the default text of "Finished at start" that this leads to, but I figured not manually setting it so that it could presumably be overwritten via i18n might be nice. That said, I'm more than happy to change this and any of the others in whatever ways seem nicest.
There was a problem hiding this comment.
I think it's ok for this! Thank you 🙏
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #233
Adding the labels required a little bit of restructuring of the page to ensure that everything was properly aligned and matched the existing layout.
Visually tested in Chrome and Safari on a Macbook Pro. Clicked on each label to verify that the corresponding field gains focus.
Finished jobs:
Failed jobs with action buttons properly aligned:
