Skip to content

Fix invalid HTML #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Fix invalid HTML #187

merged 1 commit into from
Nov 3, 2024

Conversation

frenkel
Copy link
Contributor

@frenkel frenkel commented Nov 1, 2024

I think this was invalid HTML and Firefox marked it as invalid as well. I think according to the HTML5 spec, only tags that cannot have any contents (known as void elements) can be self-closing.

@frenkel frenkel changed the title Fix invalid html Fix invalid HTML Nov 1, 2024
@rosa
Copy link
Member

rosa commented Nov 3, 2024

Oh yes, indeed! Great catch, thank you so much 🙏

@rosa rosa merged commit f8cdd68 into rails:main Nov 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants