Ensure belongs_to finder method sends a non-nil key #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I found the following weird behavior:
Let's say a
Post
belongs_to aUser
, and there is a post without auser_id
On my logs I see it tried to get
users/.xml
This PR fixes this, and returns
nil
instead:What do you think?
Additionally you might want to raise an ArgumentError when doing
Post.find nil
(same thing happens)