Skip to content

Always return a boolean value for ActiveResource::Base#exists? #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Always return a boolean value for ActiveResource::Base#exists? #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d8361
Remove line that was commented out.
stefanvermaas Jan 11, 2022
7892b1a
Make ActiveResource::Base#exists? always return a boolean value.
stefanvermaas Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/active_resource/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,13 +1072,13 @@ def delete(id, options = {})
#
# Note.exists(1349) # => false
def exists?(id, options = {})
if id
prefix_options, query_options = split_options(options[:params])
path = element_path(id, prefix_options, query_options)
response = connection.head(path, headers)
(200..206).include? response.code.to_i
end
# id && !find_single(id, options).nil?
return false unless id

prefix_options, query_options = split_options(options[:params])
path = element_path(id, prefix_options, query_options)
response = connection.head(path, headers)

(200..206).include?(response.code.to_i)
rescue ActiveResource::ResourceNotFound, ActiveResource::ResourceGone
false
end
Expand Down
24 changes: 12 additions & 12 deletions test/cases/base_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,24 +1288,24 @@ def test_delete_with_custom_header
########################################################################
def test_exists
# Class method.
assert_not Person.exists?(nil)
assert Person.exists?(1)
assert_not Person.exists?(99)
assert_equal false, Person.exists?(nil)
assert_equal true, Person.exists?(1)
assert_equal false, Person.exists?(99)

# Instance method.
assert_not Person.new.exists?
assert Person.find(1).exists?
assert_not Person.new(id: 99).exists?
assert_equal false, Person.new.exists?
assert_equal true, Person.find(1).exists?
assert_equal false, Person.new(id: 99).exists?

# Nested class method.
assert StreetAddress.exists?(1, params: { person_id: 1 })
assert_not StreetAddress.exists?(1, params: { person_id: 2 })
assert_not StreetAddress.exists?(2, params: { person_id: 1 })
assert_equal true, StreetAddress.exists?(1, params: { person_id: 1 })
assert_equal false, StreetAddress.exists?(1, params: { person_id: 2 })
assert_equal false, StreetAddress.exists?(2, params: { person_id: 1 })

# Nested instance method.
assert StreetAddress.find(1, params: { person_id: 1 }).exists?
assert_not StreetAddress.new(id: 1, person_id: 2).exists?
assert_not StreetAddress.new(id: 2, person_id: 1).exists?
assert_equal true, StreetAddress.find(1, params: { person_id: 1 }).exists?
assert_equal false, StreetAddress.new(id: 1, person_id: 2).exists?
assert_equal false, StreetAddress.new(id: 2, person_id: 1).exists?
end

def test_exists_with_redefined_to_param
Expand Down