Skip to content

Conversation

rahil-c
Copy link
Owner

@rahil-c rahil-c commented Jul 27, 2025

Change Logs

Describe context and summary for this change. Highlight if any code was copied.

Impact

Describe any public API or user-facing feature change or any performance impact.

Risk level (write none, low medium or high below)

If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@@ -130,6 +133,12 @@ public boolean needsUpgrade(HoodieTableVersion toWriteVersion) {
* @param instantTime current instant time that should not be touched.
*/
public void run(HoodieTableVersion toVersion, String instantTime) {
// Rollback any pending writes and compact before upgrade/downgrade operations
HoodieTable table = upgradeDowngradeHelper.getTable(config, context);
rollbackFailedWritesAndCompact(table, context, config, upgradeDowngradeHelper,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't invoke this for all upgrade/downgrade handlers. it depends on the exact from and to version.

So, we might have to expose two methods like below to the UpgradeHandler.

boolean needsRollbackPendingCommitAndCompact();

once we have this, we might wanna do something like below. bcoz, not all upgrade and downgrade handlers need this to be invoked.

UpgradeDowngrade.run(....) {
      loop through from to to version handlers and check if any handler returns true for needsRollbackPendingCommitAndCompact(). 
      if yes, we need to call rollback pending commits and compact. 
      if not, move on 
      .
      .
 
}

Copy link
Owner Author

@rahil-c rahil-c Jul 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented the feedback based on the notes above, let me know if rough impl looks ok to you or if the understanding was incorrect.

@rahil-c rahil-c force-pushed the rahil-c/upgrade-downgrade branch 2 times, most recently from c24c756 to 6bd9d9f Compare July 27, 2025 23:49
@rahil-c rahil-c requested a review from nsivabalan July 28, 2025 03:44
@rahil-c rahil-c force-pushed the rahil-c/upgrade-downgrade branch from 4a62097 to 63159c8 Compare July 29, 2025 00:15
@rahil-c rahil-c force-pushed the rahil-c/upgrade-downgrade branch 3 times, most recently from d707a04 to 1aabd2e Compare July 31, 2025 07:10
cshuo and others added 11 commits August 1, 2025 16:32
…d nested columns (apache#13663)

* fix bug and clean up
* refactoring to be more efficient

---------

Co-authored-by: Jonathan Vexler <=>
Co-authored-by: danny0405 <[email protected]>
…riter (apache#13672)

* fix field renaming in spark projection
* should not use full path so that we match the output of the merger
* update comments that were wrong
* avoid string handling when field is not renamed

---------

Co-authored-by: Jonathan Vexler <=>
Co-authored-by: danny0405 <[email protected]>
)

* fix restore sequence to be in completion reverse order, still requested time comparison for compaction
* add a custom comparator for the restore instant sort

---------

Co-authored-by: danny0405 <[email protected]>
@rahil-c rahil-c force-pushed the rahil-c/upgrade-downgrade branch from 1aabd2e to d571e28 Compare August 5, 2025 07:17
@rahil-c rahil-c force-pushed the rahil-c/upgrade-downgrade branch from d571e28 to cf5d939 Compare August 5, 2025 07:21
@rahil-c rahil-c force-pushed the rahil-c/upgrade-downgrade branch from 588533d to 1f39c2d Compare August 5, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants