Skip to content

Conversation

nithyatsu
Copy link
Contributor

@nithyatsu nithyatsu commented Jul 8, 2025

Description

Many AWS resources are global and not tied to a region.
This includes AWS policies, roles, users, and many other IAM entities.
There are also other resources such as route 53 and cloudfront.

Since with UDTs we are open to managing any AWS resource through a recipe, we want to remove the region requirement for valid ARNs.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 8, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository nithyatsu/radius
Commit ref ea3af9e
Unique ID funcaed3ebb689
Image tag pr-funcaed3ebb689
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcaed3ebb689
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcaed3ebb689
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcaed3ebb689
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcaed3ebb689
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcaed3ebb689
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.35%. Comparing base (2bb4845) to head (93f9a73).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9946   +/-   ##
=======================================
  Coverage   49.34%   49.35%           
=======================================
  Files         636      636           
  Lines       48778    48788   +10     
=======================================
+ Hits        24069    24078    +9     
  Misses      22878    22878           
- Partials     1831     1832    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nithyatsu nithyatsu marked this pull request as ready for review July 8, 2025 18:25
@nithyatsu nithyatsu requested review from a team as code owners July 8, 2025 18:25
@nithyatsu nithyatsu temporarily deployed to functional-tests July 8, 2025 18:28 — with GitHub Actions Inactive
Copy link
Contributor

@sylvainsf sylvainsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for walking me through the problem.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 8, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository nithyatsu/radius
Commit ref 59309f3
Unique ID funcbb884d4638
Image tag pr-funcbb884d4638
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.29.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcbb884d4638
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcbb884d4638
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcbb884d4638
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcbb884d4638
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcbb884d4638
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

nithyatsu added 2 commits July 8, 2025 13:18
Signed-off-by: nithyatsu <[email protected]>
Signed-off-by: nithyatsu <[email protected]>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 8, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository nithyatsu/radius
Commit ref 93f9a73
Unique ID func9beb020adf
Image tag pr-func9beb020adf
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.29.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func9beb020adf
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func9beb020adf
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func9beb020adf
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func9beb020adf
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func9beb020adf
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@nithyatsu nithyatsu merged commit 87b5426 into radius-project:main Jul 8, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants