Skip to content

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Jun 12, 2025

Description

The PR checklist workflow should be skipped on PRs opened by dependabot. However, this is not happening likely due to the conditional. This PR updates the conditional to check the author of the PR. A working run of the workflow can be seen here : https://github.com/radius-project/radius/actions/runs/15621471185/job/44007105593?pr=9813

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Signed-off-by: sk593 <[email protected]>
@sk593 sk593 had a problem deploying to functional-tests June 12, 2025 21:35 — with GitHub Actions Failure
@sk593 sk593 temporarily deployed to publish-bicep June 12, 2025 21:35 — with GitHub Actions Inactive
Copy link

github-actions bot commented Jun 12, 2025

Unit Tests

3 819 tests  +59   3 816 ✅ +61   6m 40s ⏱️ -32s
  304 suites ± 0       3 💤 ± 0 
    1 files   ± 0       0 ❌  -  2 

Results for commit 65c9d2f. ± Comparison against base commit b360ecb.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.24%. Comparing base (e204e97) to head (65c9d2f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9817      +/-   ##
==========================================
+ Coverage   49.21%   49.24%   +0.03%     
==========================================
  Files         634      634              
  Lines       48518    48565      +47     
==========================================
+ Hits        23876    23915      +39     
- Misses      22816    22820       +4     
- Partials     1826     1830       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sk593 sk593 marked this pull request as ready for review June 12, 2025 22:53
@sk593 sk593 requested review from a team as code owners June 12, 2025 22:53
@sk593 sk593 temporarily deployed to publish-bicep June 13, 2025 16:31 — with GitHub Actions Inactive
@sk593 sk593 temporarily deployed to functional-tests June 13, 2025 16:31 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 13, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 65c9d2f
Unique ID funce262ec317b
Image tag pr-funce262ec317b
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce262ec317b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce262ec317b
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funce262ec317b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funce262ec317b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce262ec317b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@sk593 sk593 merged commit b5db7e5 into main Jun 13, 2025
35 checks passed
@sk593 sk593 deleted the update-prchecklist branch June 13, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants