Skip to content

Conversation

lakshmimsft
Copy link
Contributor

@lakshmimsft lakshmimsft commented Aug 7, 2025

Description

Refactor functions in tf install updated per comments:
#10147 (comment)
#10147 (comment)

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • [] Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • [] Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • [] Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • [] Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@lakshmimsft lakshmimsft requested review from a team as code owners August 7, 2025 16:29
@lakshmimsft lakshmimsft changed the title Refactor functions during tf install Refactor functions in tf install Aug 7, 2025
@lakshmimsft lakshmimsft force-pushed the lakshmimsft/updatetfinstall branch from 151c974 to 03b2a5a Compare August 7, 2025 16:34
Copy link

github-actions bot commented Aug 7, 2025

Unit Tests

4 124 tests  ±0   4 121 ✅ ±0   7m 27s ⏱️ -6s
  309 suites ±0       3 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit e919712. ± Comparison against base commit 8c3b14b.

♻️ This comment has been updated with latest results.

Signed-off-by: lakshmimsft <[email protected]>
@lakshmimsft lakshmimsft force-pushed the lakshmimsft/updatetfinstall branch from 03b2a5a to e919712 Compare August 7, 2025 17:11
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 38.77551% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.00%. Comparing base (8c3b14b) to head (e919712).

Files with missing lines Patch % Lines
pkg/recipes/terraform/install.go 40.42% 24 Missing and 4 partials ⚠️
pkg/recipes/terraform/execute.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10182      +/-   ##
==========================================
- Coverage   50.01%   50.00%   -0.01%     
==========================================
  Files         642      642              
  Lines       50039    50041       +2     
==========================================
- Hits        25025    25023       -2     
+ Misses      23113    23112       -1     
- Partials     1901     1906       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Aug 7, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref e919712
Unique ID func9a24feda6b
Image tag pr-func9a24feda6b
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.29.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func9a24feda6b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func9a24feda6b
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func9a24feda6b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func9a24feda6b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func9a24feda6b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant