Automated Resyntax fixes #1395
Closed
Automated Resyntax fixes #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This is an automated change generated by Resyntax. #### Pass 1 Applied 5 fixes to [`typed-racket-lib/typed-racket/static-contracts/constraints.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/static-contracts/constraints.rkt) * Line 184, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. * Line 192, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. * Line 200, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. * Line 207, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. * Line 223, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. Applied 2 fixes to [`typed-racket-lib/typed-racket/static-contracts/structures.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/static-contracts/structures.rkt) * Line 126, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. * Line 130, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. Applied 2 fixes to [`typed-racket-lib/typed-racket/static-contracts/instantiate.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/static-contracts/instantiate.rkt) * Line 5, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 147, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. #### Pass 2 Applied 1 fix to [`typed-racket-lib/typed-racket/static-contracts/constraints.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/static-contracts/constraints.rkt) * Line 230, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. ## Summary Fixed 10 issues in 3 files. * Fixed 9 occurrences of `single-clause-match-to-match-define` * Fixed 1 occurrence of `tidy-require`
jackfirth
reviewed
Sep 27, 2024
| (contract-restrict v rec (set-add constraints con)))])) | ||
| (match-define (contract-restrict v rec constraints) cr) | ||
| (define con (constraint v max)) | ||
| (if (trivial-constraint? con) cr (contract-restrict v rec (set-add constraints con)))) |
There was a problem hiding this comment.
Another instance of sorawee/fmt#75.
Comment on lines
-228
to
+223
| (for/fold ([bvals '()] [ubids (make-immutable-free-id-table)]) | ||
| (for/fold ([bvals '()] | ||
| [ubids (make-immutable-free-id-table)]) |
There was a problem hiding this comment.
This shouldn't have been reformatted, see jackfirth/resyntax#333.
|
Closing this one in preference of making larger pull requests instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by Resyntax.
Pass 1
Applied 5 fixes to
typed-racket-lib/typed-racket/static-contracts/constraints.rktsingle-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.single-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.single-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.single-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.single-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.Applied 2 fixes to
typed-racket-lib/typed-racket/static-contracts/structures.rktsingle-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.single-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.Applied 2 fixes to
typed-racket-lib/typed-racket/static-contracts/instantiate.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.single-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.Pass 2
Applied 1 fix to
typed-racket-lib/typed-racket/static-contracts/constraints.rktsingle-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.Summary
Fixed 10 issues in 3 files.
single-clause-match-to-match-definetidy-require