Automated Resyntax fixes #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This is an automated change generated by Resyntax. #### Pass 1 Applied 1 fix to [`scribble-test/tests/scribble/latex-render.rkt`](../blob/HEAD/scribble-test/tests/scribble/latex-render.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 3 fixes to [`scribble-lib/scribble/lp/lang/common.rkt`](../blob/HEAD/scribble-lib/scribble/lp/lang/common.rkt) * Line 7, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 44, `if-let-to-cond`: `cond` with internal definitions is preferred over `if` with `let`, to reduce nesting * Line 59, `map-to-for`: This `map` operation can be replaced with a `for/list` loop. Applied 1 fix to [`scribble-test/tests/scribble/text-wrap.rkt`](../blob/HEAD/scribble-test/tests/scribble/text-wrap.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 2 Applied 1 fix to [`scribble-lib/scribble/lp/lang/common.rkt`](../blob/HEAD/scribble-lib/scribble/lp/lang/common.rkt) * Line 46, `if-begin-to-cond`: Using `cond` instead of `if` here makes `begin` unnecessary ## Summary Fixed 6 issues in 3 files. * Fixed 3 occurrences of `tidy-require` * Fixed 1 occurrence of `if-let-to-cond` * Fixed 1 occurrence of `map-to-for` * Fixed 1 occurrence of `if-begin-to-cond`
rfindler
reviewed
Sep 25, 2024
| [else (list (shift expr))])] | ||
| [else | ||
| (define subs (syntax->list expr)) | ||
| (if subs (list (restore expr (loop subs))) (list (shift expr)))])) |
There was a problem hiding this comment.
Kind of wish the if were on its own line here. Not sure if this is already accounted for in a pending change elsewhere, tho!
There was a problem hiding this comment.
Sorawee and I have some thoughts on how to address this with some future fmt changes. But for now I'd like to just let it be, since I don't think it's worth blocking the rest of the improvements on waiting for that.
|
The changes look good to me, modulo the one comment. |
jackfirth
reviewed
Sep 25, 2024
Comment on lines
58
to
+60
| (append-map (lambda (m) | ||
| (map (lambda (u) | ||
| (list (syntax-local-introduce m) | ||
| (syntax-local-introduce u))) | ||
| (mapping-get chunk-groups m))) | ||
| (for/list ([u (in-list (mapping-get chunk-groups m))]) | ||
| (list (syntax-local-introduce m) (syntax-local-introduce u)))) |
There was a problem hiding this comment.
This can be simplified further. Filed jackfirth/resyntax#323 for this.
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by Resyntax.
Pass 1
Applied 1 fix to
scribble-test/tests/scribble/latex-render.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 3 fixes to
scribble-lib/scribble/lp/lang/common.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.if-let-to-cond:condwith internal definitions is preferred overifwithlet, to reduce nestingmap-to-for: Thismapoperation can be replaced with afor/listloop.Applied 1 fix to
scribble-test/tests/scribble/text-wrap.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Pass 2
Applied 1 fix to
scribble-lib/scribble/lp/lang/common.rktif-begin-to-cond: Usingcondinstead ofifhere makesbeginunnecessarySummary
Fixed 6 issues in 3 files.
tidy-requireif-let-to-condmap-to-forif-begin-to-cond