Fix key generation #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use longer password, "dummy", instead of "a", for key generation with `make keys`. When running `make keys`, I see error messages of the form routines:UI_set_result_ex:result too small:crypto/ui/ui_lib.c:905:You must type in 4 to 1023 characters and `private-key.pem` is generated with a length of 0 bytes. According to https://bugzilla.redhat.com/show_bug.cgi?id=1467669 , this is because the used passwords are too short.
With the default key size of 1024, when I start the server with
`make compile run`, I see several stacktraces with the message
#<thread:'package-change-handler>
*** DAEMON CRASHED: main-web-server-thread ***
ssl-load-certificate-chain!: load failed from: #<path:/home/schwa/sd/racket/racket-pkg-website/src/../server-cert.pem> (error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee key too small)
context...:
jfromaniello/selfsigned#33 suggests increasing
the key size to at least 2048 bits. Increasing the key size in the
Makefile makes the above stacktraces go away.
I set the key size in the Makefile to 4096 to make it more
"future-proof", but feel free to use a key size of 2048, which works for
me as well.
LiberalArtist
added a commit
to LiberalArtist/racket-pkg-website
that referenced
this pull request
Jun 23, 2023
OpenSSL on my system refused to use certificates generated with the old parameters. Related to racket#78
jryans
pushed a commit
that referenced
this pull request
Jun 27, 2023
OpenSSL on my system refused to use certificates generated with the old parameters. Related to #78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, this PR has these changes:
Please refer to the commit messages for details.