Nack rejected messages to MQTT 5.0 client #9034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since MQTT 5.0 supports negative acknowledgements thanks to reason codes in the PUBACK packet. We could either choose reason code 128 or 131. The description code for 131 applies for rejected messages, hence this commit uses 131: > The PUBLISH is valid but the receiver is not willing to accept it.
|
For me it all makes sense, but I've found new confirms suite extremely hard to read. I got lost in those U{n} very quickly - hard to keep initial state in mind for each paragraph. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since MQTT 5.0 supports negative acknowledgements thanks to reason codes in the PUBACK packet.
We could either choose reason code 128 or 131. The description code for
131 applies for rejected messages, hence this commit uses 131: