Skip to content

rabbit_disk_monitor: handle gen_server timeouts to reduce log noise #8837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 12, 2023
Merged

rabbit_disk_monitor: handle gen_server timeouts to reduce log noise #8837

merged 4 commits into from
Jul 12, 2023

Conversation

michaelklishin
Copy link
Collaborator

References #8836.

@lukebakken lukebakken force-pushed the rabbitmq-server-8836 branch from 43ded09 to 08bf4ee Compare July 12, 2023 20:58
lukebakken
lukebakken approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested by setting the gen_server:call timeout to 0. No logging was observed because the timeout exception was caught.

@michaelklishin michaelklishin added this to the 3.12.2 milestone Jul 12, 2023
@michaelklishin michaelklishin merged commit 50e9634 into main Jul 12, 2023
@michaelklishin michaelklishin deleted the rabbitmq-server-8836 branch July 12, 2023 22:37
@mergify mergify bot mentioned this pull request Jul 12, 2023
Merged
HoloRin added a commit that referenced this pull request Jul 13, 2023
@HoloRin
Merge pull request #8843 from rabbitmq/mergify/bp/v3.12.x/pr-8837
9a6ef54 
rabbit_disk_monitor: handle gen_server timeouts to reduce log noise (backport #8837)
@ansd ansd mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken lukebakken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.12.2
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelklishin @lukebakken