Fix error popup text display #14277
Merged
Fix error popup text display #14277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When validation fails for a policy parameter, the resulting popup can't be read due to one extra binary encoding as well as code that escapes HTML entites. Since the EJS template uses `<%= >` for the popup, it will display the text as-is, and not render any HTML.
|
FTR, the removal of the escaping functions is safe: the policy or runtime parameter keys and values are validated, and unknown values are reported as pre-formatted, quoted string values. The EJS part should also be safe, as Luke explains in the PR description. I have tried it with However, this also means that we should not backport this change. |
|
@lukebakken thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validation fails for a policy parameter, the resulting popup can't be read due to one extra binary encoding as well as code that escapes HTML entites. Since the EJS template uses
<%= ... %>for the popup, it will display the text as-is, and not render any HTML.The following definitions import, when imported into a 4.x broker via the management UI, will reproduce the issue:
defs-pp.json
Popup display when current
maincode is used:Popup display when this PR is applied:
You can also observe this behavior in a 4.x broker by going to Admin -> Policies and creating a policy with
ha-mode: all