Skip to content

Conversation

lukebakken
Copy link
Collaborator

#14132 introduced a small bug in the JSON output that was caught by CI.

rabbitmq#14132 introduced a small bug in the JSON output that was caught by CI.
@lukebakken lukebakken self-assigned this Jun 25, 2025
@lukebakken
Copy link
Collaborator Author

lukebakken commented Jun 25, 2025

I'm running the failed CI suite locally to ensure this is fixed 😬

Failure:
https://github.com/rabbitmq/rabbitmq-server/actions/runs/15880235422/job/44778346713#step:11:6136

JSONFormattingTest [test/json_formatting_test.exs]
  * test JSON output of cluster_status [L#45]
  * test JSON output of cluster_status (33.9ms) [L#45]

  1) test JSON output of cluster_status (JSONFormattingTest)
     test/json_formatting_test.exs:45
     Assertion with == failed
     code:  assert doc["alarms"] == []
     left:  ""
     right: []
     stacktrace:
       test/json_formatting_test.exs:61: (test)

  * test JSON output of status [L#21]
  * test JSON output of status (68.0ms) [L#21]

  2) test JSON output of status (JSONFormattingTest)
     test/json_formatting_test.exs:21
     Assertion with == failed
     code:  assert doc["alarms"] == []
     left:  ""
     right: []
     stacktrace:
       test/json_formatting_test.exs:42: (test)

Not easy to find in the output!

@lukebakken
Copy link
Collaborator Author

Everything passes locally! Sorry for the extra PR:

Finished in 1501.6 seconds (3.8s async, 1497.8s sync)
1414 tests, 0 failures

@lukebakken lukebakken marked this pull request as ready for review June 25, 2025 19:28
@ikavgo ikavgo merged commit d685875 into rabbitmq:main Jun 25, 2025
281 of 284 checks passed
@lukebakken lukebakken deleted the rabbitmq-server-14101-3 branch June 25, 2025 19:29
@ikavgo
Copy link
Contributor

ikavgo commented Jun 25, 2025

Thank you Luke!

michaelklishin added a commit that referenced this pull request Jun 25, 2025
@michaelklishin michaelklishin added this to the 4.2.0 milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants