Do not propagate none password to http backend
#13408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcialRosales
changed the title
MarcialRosales
changed the title
none
MarcialRosales
changed the title
nonenone
MarcialRosales
force-pushed
the
mqtt-optional-password-cred
branch
2 times, most recently
from
566feb0 to
1547216
Compare
MarcialRosales
force-pushed
the
mqtt-optional-password-cred
branch
from
dbffcde to
b09bfb2
Compare
MarcialRosales
changed the title
nonenone password to http backend
6 tasks
michaelklishin
added a commit
that referenced
this pull request
Feb 25, 2025
Do not propagate `none` password to http backend (backport #13408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Do not propagate password if not provided. Internally, when a connection authenticates with a client certificate, the password credentials is set to
none. When RabbitMQ delegates the authentication to a http backend, RabbitMQ should not send a password whose value is the Erlang termnone.Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply