Extract MQTT client_id from client certificate and propagate to authnz backends #11702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcialRosales
force-pushed
the
mqtt-extract-client-id-from-cert
branch
from
1fea703 to
f1e2ac0
Compare
MarcialRosales
force-pushed
the
mqtt-extract-client-id-from-cert
branch
3 times, most recently
from
51ab5d4 to
841c245
Compare
MarcialRosales
changed the title
MarcialRosales
force-pushed
the
mqtt-extract-client-id-from-cert
branch
from
841c245 to
9329e71
Compare
MarcialRosales
force-pushed
the
mqtt-extract-client-id-from-cert
branch
from
f06bece to
5b5f2c4
Compare
ansd
requested changes
Jul 17, 2024
| @@ -66,8 +66,14 @@ sub_groups() -> | |||
| ssl_user_vhost_parameter_mapping_success, | |||
| ssl_user_vhost_parameter_mapping_not_allowed, | |||
| ssl_user_vhost_parameter_mapping_vhost_does_not_exist, | |||
| ssl_user_cert_vhost_mapping_takes_precedence_over_port_vhost_mapping | |||
| ssl_user_cert_vhost_mapping_takes_precedence_over_port_vhost_mapping | |||
There was a problem hiding this comment.
remove additional white space at end of line
ansd
reviewed
Jul 17, 2024
MarcialRosales
force-pushed
the
mqtt-extract-client-id-from-cert
branch
from
31e9c8a to
c78710f
Compare
ansd
requested changes
Jul 22, 2024
MarcialRosales
force-pushed
the
mqtt-extract-client-id-from-cert
branch
from
c758ad8 to
299f534
Compare
michaelklishin
force-pushed
the
mqtt-extract-client-id-from-cert
branch
from
299f534 to
5fc07dd
Compare
|
The forced push was a rebase. |
michaelklishin
force-pushed
the
mqtt-extract-client-id-from-cert
branch
from
5fc07dd to
3015f3b
Compare
|
@MarcialRosales can you please rebase this? The key conflict in the MQTT processor module comes from ba14b15. |
MarcialRosales
force-pushed
the
mqtt-extract-client-id-from-cert
branch
from
3015f3b to
1abc4ed
Compare
michaelklishin
approved these changes
Sep 3, 2024
6 tasks
michaelklishin
added a commit
that referenced
this pull request
Sep 3, 2024
Extract MQTT client_id from client certificate and propagate to authnz backends (backport #11702)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Address issue #9323
This plugin is accompanied by a docs PR: rabbitmq/rabbitmq-website#1976
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply