Skip to content

Conversation

aaron-seo
Copy link
Contributor

Proposed Changes

In the rabbitmqctl docs for list_unresponsive_queues, type is listed as a queueinfoitem parameter, but we noticed it didn't work and this is reflected in the source code. This commit adds type as a queueinfoitem parameter for list_unresponsive_queues.

Testing

  1. Run a broker with the change
bazel run broker RABBITMQ_NODENAME=rmq1@localhost
  1. Declare some queues
Listing queues for vhost / ...
name	pid	type
test_unresponsive_q	<[email protected]>	quorum
test_q2	<[email protected]>	quorum
test_q1	<[email protected]>	classic
test_q3		stream
  1. Make test_unresponsive_q unresponsive by suspending its process
bazel run -- rabbitmqctl -n rmq1@localhost eval 'sys:suspend(list_to_pid("<0.874.0>")).'
  1. Call list_unresponsive_queues command with type
bazel run -- rabbitmqctl -n rmq1@localhost list_unresponsive_queues name type
...
Listing unresponsive queues for vhost / ...
name	type
test_unresponsive_q	rabbit_quorum_queue

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works (note: looks like a test module doesn't exist atm for this command)
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

In the rabbitmqctl docs for list_unresponsive_queues, `type` is listed as
a queueinfoitem parameter, but this is not reflected in the source code.
This  commit adds `type` as a queueinfoitem parameter for list_unresponsive_queues.
@michaelklishin michaelklishin merged commit 57f9aec into rabbitmq:main Apr 24, 2024
michaelklishin added a commit that referenced this pull request Apr 25, 2024
rabbitmqctl: Add `type` info parameter for `list_unresponsive_queues` (backport #11079)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants