Skip to content

Improve the message logged when a channel runs into a consumer acknowledgement timeout #10446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Improve the message logged when a channel runs into a consumer acknowledgement timeout #10446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0683c4c
add consumer tag and queue name in the ack timeout warning message
rluvaton Jan 30, 2024
a188fbc
Log message wording for #10444
michaelklishin Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions deps/rabbit/src/rabbit_channel.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2780,13 +2780,15 @@ evaluate_consumer_timeout1(PA = #pending_ack{delivered_at = Time},
{noreply, State}
end.

handle_consumer_timed_out(Timeout,#pending_ack{delivery_tag = DeliveryTag},
handle_consumer_timed_out(Timeout,#pending_ack{delivery_tag = DeliveryTag, tag = ConsumerTag, queue = QName},
State = #ch{cfg = #conf{channel = Channel}}) ->
rabbit_log_channel:warning("Consumer ~ts on channel ~w has timed out "
"waiting for delivery acknowledgement. Timeout used: ~tp ms. "
rabbit_log_channel:warning("Consumer '~ts' on channel ~w and ~ts has timed out "
"waiting for a consumer acknowledgement of a delivery with delivery tag = ~b. Timeout used: ~tp ms. "
"This timeout value can be configured, see consumers doc guide to learn more",
[rabbit_data_coercion:to_binary(DeliveryTag),
Channel, Timeout]),
[ConsumerTag,
Channel,
rabbit_misc:rs(QName),
DeliveryTag, Timeout]),
Ex = rabbit_misc:amqp_error(precondition_failed,
"delivery acknowledgement on channel ~w timed out. "
"Timeout value used: ~tp ms. "
Expand Down