Skip to content

Ensure -noinput is applied correctly #10268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken self-assigned this Jan 2, 2024
@lukebakken lukebakken requested a review from mkuratczyk January 2, 2024 16:00
@lukebakken lukebakken force-pushed the rabbitmq-server-10131-followup-2 branch from 2cede8e to 38e50c7 Compare January 2, 2024 16:53
Follow-up to:
* #10131
* #10257

The following `rabbitmqctl` commands may require `stdin` input:
* `add_user`
* `authenticate_user`
* `change_password`
* `decode`
* `encode`
* `eval`
* `hash_password`

The following `rabbitmq-diagnostics` commands may require `stdin` input:
* `observer`
* `remote_shell`
@lukebakken lukebakken force-pushed the rabbitmq-server-10131-followup-2 branch from 38e50c7 to 7da7d4e Compare January 2, 2024 21:40
@lukebakken lukebakken marked this pull request as ready for review January 3, 2024 00:35
@michaelklishin michaelklishin added this to the 3.13.0 milestone Jan 3, 2024
@michaelklishin michaelklishin merged commit 5886383 into main Jan 3, 2024
@michaelklishin michaelklishin deleted the rabbitmq-server-10131-followup-2 branch January 3, 2024 14:48
michaelklishin added a commit that referenced this pull request Jan 3, 2024
Ensure `-noinput` is applied correctly (backport #10268)
mkuratczyk added a commit that referenced this pull request Apr 22, 2024
Follow-up to #10268.

There were still cases where input was ignored, eg.
`rabbitmq-diagnostics -n node observer`
michaelklishin pushed a commit that referenced this pull request Apr 22, 2024
Follow-up to #10268.

There were still cases where input was ignored, eg.
`rabbitmq-diagnostics -n node observer`
mkuratczyk added a commit that referenced this pull request Apr 23, 2024
Follow-up to #10268.

There were still cases where input was ignored, eg.
`rabbitmq-diagnostics -n node observer`
mergify bot pushed a commit that referenced this pull request Apr 23, 2024
Follow-up to #10268.

There were still cases where input was ignored, eg.
`rabbitmq-diagnostics -n node observer`

(cherry picked from commit 72dc78f)
mkuratczyk added a commit that referenced this pull request Apr 23, 2024
Follow-up to #10268.

There were still cases where input was ignored, eg.
`rabbitmq-diagnostics -n node observer`

(cherry picked from commit 72dc78f)

Co-authored-by: Michal Kuratczyk <[email protected]>
michaelklishin added a commit that referenced this pull request Jan 26, 2025
It was not listed in 7da7d4e, even though the command
accepts definitions via standard input.

References #10268.
Closes #13157.
michaelklishin added a commit that referenced this pull request Jan 26, 2025
It was not listed in 7da7d4e, even though the command
accepts definitions via standard input.

References #10268.
Closes #13157.

(cherry picked from commit 28602be)
@michaelklishin
Copy link
Collaborator

One more command slipped through the cracks #13157.

mkuratczyk pushed a commit that referenced this pull request Jan 27, 2025
It was not listed in 7da7d4e, even though the command
accepts definitions via standard input.

References #10268.
Closes #13157.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants