-
Notifications
You must be signed in to change notification settings - Fork 4k
Propagate all credentials to http backend #10200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
698abe8
to
8d513c7
Compare
2db2b32
to
7e59adc
Compare
498ebc4
to
2fc8d2b
Compare
deps/rabbitmq_auth_backend_http/src/rabbit_auth_backend_http.erl
Outdated
Show resolved
Hide resolved
These new Selenium suites are going to help a lot with catching regressions of multi-plugin, multi-backend, multi-protocol scenarios like in #10192 👏 |
michaelklishin
added a commit
that referenced
this pull request
Dec 24, 2023
Propagate all credentials to http backend (backport #10200)
michaelklishin
added a commit
that referenced
this pull request
Dec 24, 2023
A file rename required a bit of a follow-up in GHA workflows 5af5f0c |
michaelklishin
added a commit
that referenced
this pull request
Dec 24, 2023
(cherry picked from commit 5af5f0c)
michaelklishin
added a commit
that referenced
this pull request
Jan 31, 2024
michaelklishin
added a commit
that referenced
this pull request
Feb 1, 2024
michaelklishin
added a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All credentials found in the parameter
AuthProps
that therabbitmq_auth_backend_http
receives in the function calluser_login_authentication
should be propagated as HTTP request parameters to the HTTP authentication backend.Except those credentials whose name starts with
rabbit_
as these ones are internal/private.Issue raised by this discussion.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply