Skip to content

Propagate all credentials to http backend #10200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 24, 2023

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Dec 21, 2023

All credentials found in the parameter AuthProps that the rabbitmq_auth_backend_http receives in the function call user_login_authentication should be propagated as HTTP request parameters to the HTTP authentication backend.
Except those credentials whose name starts with rabbit_ as these ones are internal/private.

Issue raised by this discussion.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales requested a review from ansd December 21, 2023 11:52
@MarcialRosales MarcialRosales force-pushed the propagate_credentials_to_http_backend branch from 698abe8 to 8d513c7 Compare December 21, 2023 11:55
@MarcialRosales MarcialRosales changed the base branch from v3.12.x to main December 21, 2023 11:56
@michaelklishin michaelklishin added this to the 3.12.12 milestone Dec 21, 2023
@MarcialRosales MarcialRosales force-pushed the propagate_credentials_to_http_backend branch from 2db2b32 to 7e59adc Compare December 22, 2023 10:40
@MarcialRosales MarcialRosales force-pushed the propagate_credentials_to_http_backend branch from 498ebc4 to 2fc8d2b Compare December 22, 2023 13:54
@MarcialRosales MarcialRosales marked this pull request as ready for review December 22, 2023 14:05
@michaelklishin
Copy link
Collaborator

These new Selenium suites are going to help a lot with catching regressions of multi-plugin, multi-backend, multi-protocol scenarios like in #10192 👏

@michaelklishin michaelklishin merged commit a374f40 into main Dec 24, 2023
@michaelklishin michaelklishin deleted the propagate_credentials_to_http_backend branch December 24, 2023 00:09
michaelklishin added a commit that referenced this pull request Dec 24, 2023
Propagate all credentials to http backend (backport #10200)
@michaelklishin
Copy link
Collaborator

A file rename required a bit of a follow-up in GHA workflows 5af5f0c

michaelklishin added a commit that referenced this pull request Dec 24, 2023
@michaelklishin michaelklishin removed this from the 3.12.12 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants