Skip to content

Conversation

illotum
Copy link

@illotum illotum commented Dec 11, 2023

Proposed Changes

Add config to override location of the hostname within EC2 instance description. It is targeting cases where user has multiple interfaces on the instance, but is generic by design.

This also fixes list coercion within common discovery code and some unit tests that were ignored previously.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Further Comments

@illotum illotum marked this pull request as ready for review December 13, 2023 00:04
@michaelklishin michaelklishin added this to the 3.13.0 milestone Dec 13, 2023
@michaelklishin michaelklishin merged commit 3e5a28b into rabbitmq:main Dec 13, 2023
@michaelklishin
Copy link
Collaborator

@illotum do you think the fixed coercion part should be backported to v3.12.x and v3.11.x? If so, please submit a separate PR :)

@illotum
Copy link
Author

illotum commented Dec 13, 2023

Sure, it's unlikely to come up within v3.11 lifetime, but doesn't hurt!

@michaelklishin
Copy link
Collaborator

michaelklishin commented Dec 13, 2023

@illotum the idea is to backport what can be safely backpored, if it's only to v3.12.x, no objections from me. v3.11.x is reaching its maturity and going out of general support by the end of this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants