-
Notifications
You must be signed in to change notification settings - Fork 613
More updates for the current OTel (OpenTelemetry) conventions #1717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+37
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
de3ae7f
to
bfaaaf7
Compare
bfaaaf7
to
9441467
Compare
5783b50
to
3532cba
Compare
- Swap order of queue name and operation in Activity name - Add messaging.operation.name tag
3532cba
to
b5ebf85
Compare
lukebakken
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @iinuwa
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
This was referenced Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update to latest OTel conventions
messaging.operation.name
tagBuilds on #1716.
Fixes #1715.
In order to get 7.0 released, this can wait until 7.1.
Types of Changes
What types of changes does your code introduce to this project?
Checklist
CONTRIBUTING.md
documentFurther Comments
Regarding #1715 (comment), I used
fetch
instead ofpolling fetch
orbasic.get
because:basic_
prefix.basic.get
.fetch
(in my mind) conveys a pull operation to me and is meaningfully distinguished fromdeliver
.