Skip to content

remove user name in case of tls #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

remove user name in case of tls #57

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b5b022
remove user name in case of tls
Gsantomaggio Jul 30, 2025
a48de99
Update pkg/rabbitmqamqp/amqp_connection_test.go
Gsantomaggio Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/rabbitmqamqp/amqp_connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,10 @@ func (a *AmqpConnection) open(ctx context.Context, address string, connOptions *
WriteTimeout: connOptions.WriteTimeout,
}
azureConnection, err = amqp.Dial(ctx, address, amqpLiteConnOptions)
if err != nil && (connOptions.TLSConfig != nil || uri.Scheme == AMQPS) {
Error("Failed to open TLS connection", fmt.Sprintf("%s://%s", uri.Scheme, uri.Host), err, "ID", connOptions.Id)
return fmt.Errorf("failed to open TLS connection: %w", err)
}
if err != nil {
Error("Failed to open connection", ExtractWithoutPassword(address), err, "ID", connOptions.Id)
return fmt.Errorf("failed to open connection: %w", err)
Expand Down
12 changes: 12 additions & 0 deletions pkg/rabbitmqamqp/amqp_connection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,4 +164,16 @@ var _ = Describe("AMQP connection Test", func() {
}()
})

Describe("AMQP TLS connection should fail with error.", func() {
tlsConfig := &tls.Config{}

// Dial the AMQP server with TLS configuration
connection, err := Dial(context.Background(), "amqps://does_not_exist:5671", &AmqpConnOptions{
TLSConfig: tlsConfig,
})
Expect(connection).To(BeNil())
Expect(err).NotTo(BeNil())
Expect(err.Error()).To(ContainSubstring("failed to open TLS connection"))
})

})
1 change: 1 addition & 0 deletions pkg/rabbitmqamqp/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (

// public consts

const AMQPS = "amqps"
const StreamFilterValue = "x-stream-filter-value"

const (
Expand Down