Fix rare fd leaks in follower. #553
Merged
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
fix-rare-fd-leak-in-follower
branch
from
4355ef1 to
2ede9e4
Compare
kjnilsson
changed the title
In the case where an append entries rpc is received that does not also validate the log it was possible to leak file handles if the check of the previous index required a read from a disk segment. Also fix a potential leak with mismatched terms
kjnilsson
force-pushed
the
fix-rare-fd-leak-in-follower
branch
from
2ede9e4 to
66de28e
Compare
michaelklishin
added a commit
that referenced
this pull request
Jul 24, 2025
michaelklishin
added a commit
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where an append entries rpc is received that does not also validate the log it was possible to leak file handles if the check of the previous index required a read from a disk segment.