Skip to content

Replaced filter_desc with dynamic label checking #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kubajal
Copy link
Contributor

@kubajal kubajal commented Aug 17, 2025

This PR:

  1. replaces filter_desc functionality with checking matching test labels in the runtime by comparing the selectors with current stack maintained by local_description_push
  2. Also, instead of checking for string-string equality, it checks for string-regex matching; this gives more flexibility in selecting subsets of tests

Fixes #2222

To do: increase test coverage and fix snapshot failures (I don't know how to do that).

@hadley
Copy link
Member

hadley commented Aug 19, 2025

As I mentioned in the issue, I don't think this is a good idea, sorry.

@hadley hadley closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select dynamically created tests using filter_desc
2 participants