Disable skipping if only one snapshot left #2174
Merged
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need variant for single file case: no file select drop down, no skip. Now we have |
|
@jennybc can you please take another look? Now that we both understand where the problem is, I think this solution should be much more compelling 😄 |
jennybc
approved these changes
Aug 13, 2025
There was a problem hiding this comment.
This works well for me now.
Through the process of reviewing/discussing this, I've also refined my mental model around what's actually going on during snapshot review. It has helped me to realize that the app's buttons really are just a way to present choices around "what are we going to do about _snaps/xyz.new.md?".
|
That's great to hear. It also helped my mental model, especially adding the reject button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2025