setup-r-dependencies installs pandoc, even if it is already installed

[gaborcsardi]

See https://github.com/rstudio/bookdown/actions/runs/8093487287/job/22116249909?pr=1457#step:8:2978

[cderv]

Setting install-pandoc: false did not work 🤔
https://github.com/rstudio/bookdown/actions/runs/8093748312/job/22117001429?pr=1457

So maybe this is something with the outputs handling in the action steps, and Sys.which("pandoc") correctly finds it.

Running simple actions tests shows that Sys.which("pandoc") correctly finds the right action
https://github.com/cderv/test-actions/actions/runs/8093870251/job/22117380020#step:5:23

[cderv]

This would be because the steps.output is a string.

Here is the debug version of previous run
https://github.com/rstudio/bookdown/actions/runs/8093748312/job/22117729189?pr=1457#step:8:9169

From https://docs.github.com/en/actions/learn-github-actions/expressions#operators

steps.<step_id>.outputs.<output_name> evaluates as a string. You need to use specific syntax to tell GitHub to evaluate an expression rather than treat it as a string. For more information, see "Contexts."

So it probably needs a fromJSON or just a if: ${{ steps.check-pandoc.outputs.install == 'true' }}

Hope it helps

[cderv]

Thanks. I am testing the branch following 0ed4cdf - it should fix both issues

[cderv]

The commit fixed both problems. So I don't need install-pandoc: false anymore. pandoc is found on PATH and not installed.

Thank you !

[gaborcsardi]

This is now fixed in @v2.

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue