Skip to content

Make method definition more similar to S3 #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 19, 2021
Merged

Make method definition more similar to S3 #368

merged 25 commits into from
Dec 19, 2021

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 17, 2021 •
edited
Loading

All setMethod() calls refer to top-level functions. Advantages:

  • From the list of files it's obvious which methods are implemented
  • Code is easier to read and navigate
  • The source code of the implementation of an S4 method can be displayed easily via duckdb:::method__signature

krlmlr added 24 commits December 19, 2021 11:01
@krlmlr
Remove argument name
5ecfe6b
@krlmlr
Tokens
290876f
@krlmlr
Split with https://github.com/pre-processing-r/rpp/blob/main/script/u…
882412d 
…n-s4.R (1)
@krlmlr
Split with https://github.com/pre-processing-r/rpp/blob/main/script/u…
5974d08 
…n-s4.R (2)
@krlmlr
Manual split
acfef14
@krlmlr
Manual split
c778158
@krlmlr
Manual split
5316ba1
@krlmlr
Manual split
561ffa3
@krlmlr
Split with https://github.com/pre-processing-r/rpp/blob/main/script/u…
4774231 
…n-s4.R (3)
@krlmlr
Move away
b061dbc
@krlmlr
Split with https://github.com/pre-processing-r/rpp/blob/main/script/u…
7ca3f3f 
…n-s4.R (4)
@krlmlr
Split with https://github.com/pre-processing-r/rpp/blob/main/script/u…
3b92abd 
…n-s4.R (5)
@krlmlr
Split with https://github.com/pre-processing-r/rpp/blob/main/script/u…
a9829c4 
…n-s4.R (6)
@krlmlr
Rename
e28064d
@krlmlr
Remove include
da58d8a
@krlmlr
Rename
e6eac64
@krlmlr
Join
35aaab0
@krlmlr
Redistribute
472b581
@krlmlr
Rename
c153a7f
@krlmlr
Redistribute
159fea7
@krlmlr
Remove
77db75b
@krlmlr
Document
3d8fee2
@krlmlr
Suggest DBItest for auto-documentation
a0c22fd
@krlmlr
Use dev DBItest on check
3e4d3f1
@krlmlr krlmlr merged commit d6e6d7a into main Dec 19, 2021
@krlmlr krlmlr deleted the f-split branch December 19, 2021 10:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krlmlr