Server Side Keep-Alive #1359
Open
Server Side Keep-Alive #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #1275
The server can send pings just like the client to keep a WS alive. No pong logic seems to be required. This ping from the server should be immune to chrome's throttling, and I left the client side ping in to inform the client if the connection fails. The failure should report shortly after waking up the tab, or more likely, right away if the closure of the WS was graceful.
Note: I was never able to reproduce the original issue. I think this fix may also fail on firefox if the tab goes into full suspension due to low system resources, but testing is needed.