Fixes init_qwat and upgrade_db.sh #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
reviewed also by @mhugo :) >> merging |
elemoine
reviewed
Feb 22, 2018
| DBTEST_HOST=$(sed -n -e "/^\[qwat_test]/,/^\[/ p" ~/.pg_service.conf | grep "^host" | cut -d"=" -f2) | ||
| DBTEST_PORT=$(sed -n -e "/^\[qwat_test]/,/^\[/ p" ~/.pg_service.conf | grep "^port" | cut -d"=" -f2) | ||
|
|
||
| if [ ! -z "$DBCOMP_HOST" ]; then |
There was a problem hiding this comment.
Any difference between ! -z and -n?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace more gnued/linuxism script
1.1. getopt
Using long args with getopt is a linuxism. So I include a "compat mode" for it. More details on stackoverflow
1.2. sed
sed ris the GNU sed version. Use coreutils with gsed for non linux. Or easiest, usecat1.3. sleep
Use only the number of seconds without the suffix.
upgrade_db.sh
2.1. SCRIPTDIR
Add the location of the script. Since you can run it everywhere
2.2. DB info from pg_service.conf
TODO is done. Get the host and the port for dbcomp and dbtest.
Maybe add an option for the location of .pg_service.conf?
Wouldn't it be better if this part were done by PUM?