Docs: Recommend async functions over assert.async() #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the simple example from the documentation, the timeout problem doesn’t actually occur (if fetchDouble() synchronously throws an Error, QUnit reports a test failure despite the assert.async() still being outstanding), but in more complicated tests it can still happen. We’ve recently migrated some tests in MediaWiki core and extensions to async+await syntax – see [1], [2], [3]. [1]: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1026171 [2]: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1106934 [3]: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1188501
The committers listed above are authorized under a signed CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the simple example from the documentation, the timeout problem doesn’t actually occur (if
fetchDouble()synchronously throws an Error, QUnit reports a test failure despite theassert.async()still being outstanding), but in more complicated tests it can still happen. We’ve recently migrated some tests in MediaWiki core and extensions to async+await syntax – see 1, 2, 3.