Skip to content

[BUG] Apply create_partitions to historical validate #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2021
Merged

[BUG] Apply create_partitions to historical validate #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cebe69
Apply create_partitions to historical validate.
moromimay Mar 30, 2021
329ef4e
Remove comments and adjusts.
moromimay Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions butterfree/load/writers/historical_feature_store_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ def validate(
Raises:
AssertionError: if count of written data doesn't match count in current
feature set dataframe.

"""
table_name = (
f"{feature_set.name}"
Expand All @@ -240,7 +239,9 @@ def validate(
written_count = (
spark_client.read(
self.db_config.format_,
path=self.db_config.get_path_with_partitions(table_name, dataframe),
path=self.db_config.get_path_with_partitions(
table_name, self._create_partitions(dataframe)
),
).count()
if self.interval_mode and not self.debug_mode
else spark_client.read_table(table_name).count()
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from setuptools import find_packages, setup

__package_name__ = "butterfree"
__version__ = "1.2.0.dev3"
__version__ = "1.2.0.dev4"
__repository_url__ = "https://github.com/quintoandar/butterfree"

with open("requirements.txt") as f:
Expand Down