Skip to content

Conversation

quinnj
Copy link
Owner

@quinnj quinnj commented Jun 5, 2023

The previous code was assuming that length(x) was comparable to each eachindex(x), which isn't always true for weird non-linear arrays.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 83.33% and no project coverage change.

Comparison is base (b23f72b) 89.69% compared to head (9c3e910) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          10       10           
  Lines        1775     1775           
=======================================
  Hits         1592     1592           
  Misses        183      183           
Impacted Files Coverage Δ
src/write.jl 84.68% <83.33%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@quinnj quinnj merged commit 7c6d69a into main Jun 5, 2023
@quinnj quinnj deleted the jq-array-eachindex-fix branch June 5, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant