Use sizeof rather than length for file length check
#260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
reviewed
Jun 3, 2023
This issue only seems to occur when there is a file with contents that contained just enough Unicode characters to push the `sizeof` value over 254 while keeping `length` under that limit.
MichaelHatherly
force-pushed
the
mh/file-length-check
branch
from
bc03ce0 to
f0df3c6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 10 10
Lines 1775 1775
=======================================
Hits 1592 1592
Misses 183 183
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue only seems to occur when there is a file with contents that contained just enough Unicode characters to push the
sizeofvalue over 254 while keepinglengthunder that limit. I'd assume thatisfilereally actually cares about number of bytes rather than apparent character length.