Read files directly

[onetonfoot]

No description provided.

[mcmcgrath13]

Thanks! Could you also update the type generation uses of JSON.read to no longer do the file checks? Seems like it shouldn't be necessary anymore with this change.

[mcmcgrath13]

Sorry for the add on, but could you also add a test for this?

[codecov]

Codecov Report

Base: 88.36% // Head: 88.37% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (efb0b0c) compared to base (8569ff9).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head efb0b0c differs from pull request most recent head 2ae5e08. Consider uploading reports for the commit 2ae5e08 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   88.36%   88.37%           
=======================================
  Files           9        9           
  Lines        1728     1729    +1     
=======================================
+ Hits         1527     1528    +1     
  Misses        201      201           

Impacted Files	Coverage Δ
src/read.jl	88.62% <100.00%> (+0.03%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[onetonfoot]

Good thing you asked for some test cases, it wasn't behaving as expected when reading types

[rafaqz]

Any chance we can get this merged?

[quinnj]

wait, why are we not using read_json_str here anymore?

[mcmcgrath13]

read now does what read_json_str did, so it's redundant

[quinnj]

ah got it.

[quinnj]

@mcmcgrath13 does this look good to you? I think it LGTM

[mcmcgrath13]

LGTM - Thank you!