Skip to content

Conversation

visr
Copy link
Contributor

@visr visr commented Aug 13, 2019

Fixes #22

This patch should not have any effect on 64 bit systems.

Alternatively we can define these additional methods, not sure what is better.

object(tapelen::Int32) = OBJECT | convert(UInt64, tapelen)
array(tapelen::Int32)  = ARRAY  | convert(UInt64, tapelen)
eltypelen(T, len::Int32) = T | convert(UInt64, len)
string(len::Int32) = STRING | convert(UInt64, len)

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #23 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage    93.6%   93.79%   +0.19%     
==========================================
  Files           7        7              
  Lines        1032     1032              
==========================================
+ Hits          966      968       +2     
+ Misses         66       64       -2
Impacted Files Coverage Δ
src/show.jl 58.82% <ø> (+5.88%) ⬆️
src/read.jl 98.36% <100%> (ø) ⬆️
src/JSON3.jl 78.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ab02e...38ebd30. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #23 into master will decrease coverage by 1.74%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage    93.6%   91.86%   -1.75%     
==========================================
  Files           7        7              
  Lines        1032     1032              
==========================================
- Hits          966      948      -18     
- Misses         66       84      +18
Impacted Files Coverage Δ
src/read.jl 98.36% <100%> (ø) ⬆️
src/JSON3.jl 78.57% <100%> (ø) ⬆️
src/show.jl 0% <0%> (-52.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ab02e...e6464ba. Read the comment docs.

Copy link
Owner

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quinnj quinnj merged commit b43c9b2 into quinnj:master Aug 13, 2019
@visr visr deleted the 32bit branch August 13, 2019 16:17
@visr
Copy link
Contributor Author

visr commented Aug 13, 2019

Great, thanks! You may still want to enable AppVeyor, or add 32 bit Windows to Travis, to make sure it stays working.

@quinnj
Copy link
Owner

quinnj commented Aug 13, 2019

Ah yes, done! https://ci.appveyor.com/project/quinnj/json3-jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

32 bit not working
2 participants