perf: display stats when drive tasks are cancelled by ctrl-c or timeout #2300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormshield-damiend
force-pushed
the
quinn_perf_duration_stats
branch
from
e185553 to
1e27cc3
Compare
stormshield-damiend
force-pushed
the
quinn_perf_duration_stats
branch
from
1e27cc3 to
81ee331
Compare
stormshield-damiend
force-pushed
the
quinn_perf_duration_stats
branch
2 times, most recently
from
78273a6 to
6125b56
Compare
stormshield-damiend
force-pushed
the
quinn_perf_duration_stats
branch
from
6125b56 to
ab4eca2
Compare
|
For reference, download only mode is broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress and is placed here for discussion.
This allow uploading or downloading an infinite amount of bytes for a given duration and still have throughput statistics at the end of the duration.
Under the hood, this is a big rework of async tasks to spawn them. It uses two tokio CancellationTokens to first stop the
drive_unianddrive_bitasks, then stop the statistics tasks after having collected the statistics.It work fine with upload only and download only but if you do upload and download at the same time (the default cas without any arguments), the download statistics are broken.
I did not tested the
drive_unipart for now.Example of call :