-
Notifications
You must be signed in to change notification settings - Fork 92
Format quilt3 #4541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format quilt3 #4541
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4541 +/- ##
=======================================
Coverage 39.09% 39.09%
=======================================
Files 852 852
Lines 36845 36844 -1
Branches 6016 6016
=======================================
Hits 14404 14404
+ Misses 21211 21210 -1
Partials 1230 1230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost LGTM
@sir-sigurd wdyt about quotes? should we enforce double quotes or just preserve existing style? |
I think so, but probably it should be done in a separate PR because it's straightforward and basically needs no review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR implements a comprehensive code formatting initiative using Ruff across the entire api/python
directory of the Quilt repository. The changes standardize Python code style by applying consistent formatting rules including: proper indentation and line breaks, trailing commas in multi-line constructs, improved docstring formatting, better multi-line expression handling, and consistent whitespace usage.
Key technical changes include:
- Configuration updates: Removed exclusion of auto-generated GraphQL client files from Ruff formatting in
pyproject.toml
and added automatic formatting to the GraphQL code generation process - CI workflow enhancements: Split the linting job into separate
lint-quilt3
andformat-quilt3
jobs to enable format checking specifically for theapi/python
directory - Selective formatting exclusions: Added
# fmt: off
directives to preserve original formatting in generated/vendored code files likebase_client.py
- Comprehensive formatting: Applied consistent formatting across 40+ Python files including core modules (
api.py
,packages.py
,data_transfer.py
), test files, and admin utilities
The changes follow Python PEP 8 guidelines and modern formatting conventions, improving code readability while maintaining identical functionality. The formatting rules ensure consistent style for multi-line constructs, string literals, function calls, and data structures. This establishes a foundation for automated code quality enforcement through CI checks, preventing future formatting inconsistencies and reducing style-related discussions in code reviews.
Confidence score: 5/5
- This PR is extremely safe to merge with no functional risks whatsoever
- Score reflects that all changes are purely cosmetic formatting improvements with zero impact on code behavior or functionality
- No files require special attention as this is a standard code formatting initiative using an established tool
38 files reviewed, 1 comment
Format all the code under
api/python
with Ruff and enable the format checking CI job