Athena refactoring with discriminating union #4529
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…/quilt into athena-execution-loading-state
Move early return conditions into setValue callback for consistent code structure:
- useDatabase: consolidate !hasData check with other conditions
- useCatalogName: consolidate !hasData check with other conditions
- useQuery: consolidate !hasData check with other conditions
- useQueryBody: consolidate !isReady check with other conditions
This creates a uniform pattern where all state selection logic
is contained within a single setValue((v) => {...}) callback,
improving code readability and maintainability.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4529 +/- ##
===========================================
+ Coverage 38.01% 57.27% +19.26%
===========================================
Files 826 32 -794
Lines 36470 2308 -34162
Branches 5977 0 -5977
===========================================
- Hits 13864 1322 -12542
+ Misses 22085 986 -21099
+ Partials 521 0 -521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-discriminating-union
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO
optipngon any new PNGsbuild.pyfor new docstrings