Skip to content

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jul 31, 2025

Description

  • "Create package" button on List view too when no packages
  • Show <NoValue> when commit message is "None"
  • Handle JSON parsing exceptions with react-error-boundaries

TODO

  • Unit tests
  • Security: Confirm that this change meets security best practices and does not violate the security model
  • Open and Embed: Confirm that this change doesn't break Open variant and Embed widget
  • Documentation
    • run optipng on any new PNGs
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quilt.bio)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 1.04167% with 95 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.96%. Comparing base (0f9e2f7) to head (75bd52a).

Files with missing lines Patch % Lines
catalog/app/containers/Bucket/PackageList.tsx 0.00% 28 Missing ⚠️
catalog/app/containers/Search/Search.tsx 0.00% 21 Missing ⚠️
catalog/app/containers/Search/NoResults.tsx 0.00% 18 Missing ⚠️
catalog/app/containers/Search/List/index.tsx 0.00% 8 Missing ⚠️
catalog/app/containers/Search/model.ts 11.11% 8 Missing ⚠️
catalog/app/containers/Search/Table/index.tsx 0.00% 7 Missing ⚠️
catalog/app/containers/Search/Layout/Results.tsx 0.00% 3 Missing ⚠️
catalog/app/containers/Search/Table/CellValue.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4463      +/-   ##
==========================================
- Coverage   37.98%   37.96%   -0.02%     
==========================================
  Files         825      825              
  Lines       36413    36430      +17     
  Branches     5961     5954       -7     
==========================================
+ Hits        13831    13832       +1     
- Misses      21356    22077     +721     
+ Partials     1226      521     -705     
Flag Coverage Δ
api-python 91.66% <ø> (ø)
catalog 17.85% <1.04%> (-0.01%) ⬇️
lambda 92.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant