-
Notifications
You must be signed in to change notification settings - Fork 92
Freeform search: fix handling of 'size' and 'from' parameters #4432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4432 +/- ##
=======================================
Coverage 38.64% 38.64%
=======================================
Files 795 795
Lines 35269 35269
Branches 5395 5395
=======================================
Hits 13628 13628
Misses 21095 21095
Partials 546 546
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Fixed a bug in freeform search query parameter handling in ElasticSearch, specifically addressing issues with 'size' and 'from' parameters in catalog search.
- Fixed incorrect parameter assignment where
query.sizewas being used for the 'from' parameter incatalog/app/containers/Bucket/Queries/requests/search.ts - Modified parameter validation to properly handle zero values instead of treating them as falsy in search requests
- Added CHANGELOG.md entry documenting the freeform search parameter fix
2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Description
TODO