Skip to content

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Jul 9, 2025

Description

TODO

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@sir-sigurd sir-sigurd changed the title Freeform search: pass size and from set to 0 to backend Freeform search: pass 'size' and 'from' set to 0 to backend Jul 9, 2025
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.64%. Comparing base (e400f49) to head (815c0bc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...g/app/containers/Bucket/Queries/requests/search.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4432   +/-   ##
=======================================
  Coverage   38.64%   38.64%           
=======================================
  Files         795      795           
  Lines       35269    35269           
  Branches     5395     5395           
=======================================
  Hits        13628    13628           
  Misses      21095    21095           
  Partials      546      546           
Flag Coverage Δ
api-python 91.41% <ø> (ø)
catalog 17.71% <0.00%> (ø)
lambda 91.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sir-sigurd sir-sigurd marked this pull request as ready for review July 9, 2025 11:30
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed a bug in freeform search query parameter handling in ElasticSearch, specifically addressing issues with 'size' and 'from' parameters in catalog search.

  • Fixed incorrect parameter assignment where query.size was being used for the 'from' parameter in catalog/app/containers/Bucket/Queries/requests/search.ts
  • Modified parameter validation to properly handle zero values instead of treating them as falsy in search requests
  • Added CHANGELOG.md entry documenting the freeform search parameter fix

2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile

sir-sigurd and others added 2 commits July 9, 2025 13:35
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@sir-sigurd sir-sigurd changed the title Freeform search: pass 'size' and 'from' set to 0 to backend Freeform search: fix handling of 'size' and 'from' parameters Jul 9, 2025
@sir-sigurd sir-sigurd requested a review from nl0 July 9, 2025 11:38
@nl0 nl0 added this pull request to the merge queue Jul 9, 2025
Merged via the queue into master with commit 2ea20e4 Jul 9, 2025
35 of 37 checks passed
@nl0 nl0 deleted the fix-freeform branch July 9, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants