Skip to content

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Jun 30, 2025

Description

TODO

@sir-sigurd sir-sigurd requested a review from nl0 July 14, 2025 11:51
nl0
nl0 previously approved these changes Jul 15, 2025
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tho it would be nice to have more type coverage.
do you plan on addressing the rest of the TODO/XXX comments?

This reverts commit 9801de7.
This reverts commit e8731ac.
@sir-sigurd sir-sigurd requested a review from nl0 July 15, 2025 12:52
@sir-sigurd sir-sigurd enabled auto-merge July 15, 2025 13:17
@sir-sigurd sir-sigurd added this pull request to the merge queue Jul 15, 2025
Merged via the queue into master with commit e0ae23a Jul 15, 2025
38 of 39 checks passed
@sir-sigurd sir-sigurd deleted the index-pkg-entries-2 branch July 15, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants