Respect cfg.packageRoot when creating text files using UI

[fiskus]

• Encapsulate the fact that we prefix files in s3 with package name into s3paths.canonicalKey function
• Resolve some tech dept and move routes functions used for FileEditor into FileEditor/routes.ts

• Unit tests
• Changelog entry (skip if change is not significant to end users, e.g. docs only)

[codecov]

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 38.72%. Comparing base (21fbe9a) to head (1b708a1).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
catalog/app/components/FileEditor/CreateFile.tsx	30.00%	7 Missing ⚠️
.../app/containers/Bucket/PackageTree/PackageTree.tsx	0.00%	3 Missing ⚠️
...iners/Bucket/PackageDialog/PackageCreationForm.tsx	0.00%	1 Missing ⚠️
...og/app/containers/Bucket/PackageDialog/Uploads.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4397      +/-   ##
==========================================
+ Coverage   38.69%   38.72%   +0.02%     
==========================================
  Files         795      795              
  Lines       35208    35211       +3     
  Branches     5384     5384              
==========================================
+ Hits        13625    13636      +11     
+ Misses      21037    21029       -8     
  Partials      546      546              

Flag	Coverage Δ
api-python	91.41% <ø> (ø)
catalog	17.78% <70.73%> (+0.04%)	⬆️
lambda	91.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[greptile-apps]

PR Summary

This PR refactors file path handling in the UI to properly support package root prefixing when creating and editing files in packages, introducing a new s3paths.canonicalKey function to centralize path generation logic.

• Hardcoded packageRoot value 'r/o/o/t' in Config.ts overrides configuration, potentially breaking custom package root setups
• New canonicalKey function in s3paths.ts needs more comprehensive test coverage for edge cases
• Refactored FileEditor routes to use hooks pattern, improving code organization but increasing complexity
• Simplified file path handling in PackageCreationForm and Uploads components by using canonicalKey instead of manual path manipulation
• Changed useAddFileInPackage and useEditFileInPackage hooks to return functions that accept paths, supporting better package root handling

_{10 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile}

[nl0]

mostly lgtm, some nitpicks inline