Skip to content

Conversation

@nl0
Copy link
Member

@nl0 nl0 commented Apr 23, 2025

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 38.68%. Comparing base (3c8e547) to head (e6dcdae).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
catalog/app/utils/Navigation.ts 25.00% 9 Missing ⚠️
catalog/app/components/Assistant/Model/Tool.ts 25.00% 3 Missing ⚠️
...omponents/Assistant/Model/GlobalContext/preview.ts 0.00% 1 Missing ⚠️
catalog/app/containers/Bucket/Workflows/search.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4387      +/-   ##
==========================================
- Coverage   38.68%   38.68%   -0.01%     
==========================================
  Files         795      795              
  Lines       35186    35186              
  Branches     5589     5589              
==========================================
- Hits        13613    13612       -1     
- Misses      20375    20376       +1     
  Partials     1198     1198              
Flag Coverage Δ
api-python 91.41% <ø> (ø)
catalog 17.70% <41.66%> (-0.01%) ⬇️
lambda 91.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nl0 nl0 marked this pull request as ready for review April 23, 2025 11:51
@nl0 nl0 requested a review from fiskus April 23, 2025 11:51
@nl0 nl0 enabled auto-merge April 23, 2025 11:51
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the effect-related dependencies and adjusts imports across multiple files in the catalog application. Here's a summary of the key changes:

  • Updates imports from '@effect/schema' to 'effect' as the schema functionality has been merged into the main effect package
  • Updates @effect/platform from ^0.67.1 to ^0.80.13 and effect from ^3.10.19 to ^3.14.13
  • Adjusts Jest configuration to handle the new msgpackr dependency
  • Removes @effect/schema package as it's now part of effect
  • Updates imports to use Schema through the Eff namespace
  • Updates Jest snapshots to reflect the changes

The changes are primarily focused on dependency updates and import path adjustments, with no functional changes to the codebase.

13 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@nl0 nl0 added this pull request to the merge queue Apr 23, 2025
Merged via the queue into master with commit b8ac3aa Apr 23, 2025
37 checks passed
@nl0 nl0 deleted the bump-effect branch April 23, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants