Skip to content

Mention removed top_hash parameter in push() docs #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Mention removed top_hash parameter in push() docs #4116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f05c89b
Mention removed top_hash parameter in `push()` docs
sir-sigurd Aug 21, 2024
0603c6f
Merge branch 'master' into push-dest-docs
sir-sigurd Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/python/quilt3/packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,6 +1386,7 @@ def push(
name: name for package in registry
dest: where to copy the objects in the package. Must be either an S3 URI prefix (e.g., s3://$bucket/$key)
in the registry bucket, or a callable that takes logical_key and package_entry, and returns an S3 URI.
(Changed in 6.0.0a1) previously top_hash was passed to the callable dest as a third argument.
registry: registry where to create the new package
message: the commit message for the new package
selector_fn: An optional function that determines which package entries should be copied to S3.
Expand Down
1 change: 1 addition & 0 deletions docs/api-reference/Package.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ __Arguments__
* __name__: name for package in registry
* __dest__: where to copy the objects in the package. Must be either an S3 URI prefix (e.g., s3://$bucket/$key)
in the registry bucket, or a callable that takes logical_key and package_entry, and returns an S3 URI.
(Changed in 6.0.0a1) previously top_hash was passed to the callable dest as a third argument.
* __registry__: registry where to create the new package
* __message__: the commit message for the new package
* __selector_fn__: An optional function that determines which package entries should be copied to S3.
Expand Down