Skip to content

add unit for clarity #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add unit for clarity #331

wants to merge 1 commit into from

Conversation

MarcoPolo
Copy link

Adding milliseconds here makes it clear that the values above 2^14 milliseconds are invalid. The distinction helps because the field is in microseconds, but the limit and reference are in milliseconds.

@MarcoPolo
add unit for clarity
3633ade 
Adding milliseconds here makes it clear that the values above 2^14
_milliseconds_ are invalid. The distinction helps because the field is
in microseconds, but the limit and reference are in milliseconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianswett ianswett ianswett approved these changes

+1 more reviewer

@kazuho kazuho kazuho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoPolo @kazuho @ianswett