Skip to content

fix TLS error in praseing PCAP #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix TLS error in praseing PCAP #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/parsers/ParserPCAP.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export class ParserPCAP {

let foundCryptoFrame = undefined;
for ( const rawFrame of rawFrames ) {
if ( PCAPUtil.ensurePathExists("tls.handshake/tls.handshake.type", rawFrame, false ) ) {
if ( PCAPUtil.ensurePathExists("tls/tls.handshake/tls.handshake.type", rawFrame, false ) ) {
foundCryptoFrame = rawFrame;
break;
}
Expand All @@ -145,7 +145,7 @@ export class ParserPCAP {
this.exit("ParserPCAP: no tls info known for the first QUIC initial, not supported! Are you sure the trace decrypted?", rawPacket, rawPacket["quic.frame"] );
}
else {
if ( foundCryptoFrame["tls.handshake"]["tls.handshake.type"] !== "1" ){ // 1 === ClientHello. 2 === ServerHello
if ( foundCryptoFrame["tls"]["tls.handshake"]["tls.handshake.type"] !== "1" ){ // 1 === ClientHello. 2 === ServerHello
this.exit("ParserPCAP: first QUIC initial in this trace is ServerHello. Pcap2qlog needs the ClientHello to work properly.", rawPackets);
}
else {
Expand Down